Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J Updaters: use isRowVectorOrScalar for updaters with 1x parameters #6671

AlexDBlack opened this issue Nov 6, 2018 · 1 comment · Fixed by #6729


Copy link

commented Nov 6, 2018

This is an edge case that really won't happen in practice but we might as well fix it to be technically correct:
[1,1] isn't a row vector, but optimizing 1 parameter with say RmsProp isn't possible because of using isRowVector()

Updaters with state size 2x the number of parameters (Adam, etc) can't have a state size of 1 so this isn't an issue there.

nadheesh added a commit to nadheesh/deeplearning4j that referenced this issue Nov 15, 2018
AlexDBlack added a commit that referenced this issue Nov 21, 2018
Various DL4J/ND4J fixes (#6729)
* #6728 InvertMatrix edge case fix

* #6671 Updaters - use isRowVectorOrScalar when appropriate

* #6717 Report (optionally) GC info in PerformanceListener

* #6714 Don't generate instance ID for ops when using INDArray constructors

* #6712 Fix FileDocumentIterator handling of empty documents

* #6686 ArchiveUtils listing, single file extraction for zip

* SameDiff: don't make output variables placeholders if shape is unknown

* #6674 SameDiff FlatBuffers: persist placeholder variables

* #6674 SameDiff FlatBuffers: persist placeholder variables

* #6691 DL4J CuDNN: don't fall back to built-in if exception is OOM

* Add graph.fbs changes (forgotten in previous commit)

* LRN builder constructor fix

* Fix test typo

* Dependency management for nd4j-kryo jackson versions to (try to) avoid CI dependency issue

This comment has been minimized.

Copy link

commented Dec 21, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Dec 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
1 participant
You can’t perform that action at this time.