Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SameDiff: Some Conv TF import properties can't be resolved on import #7008
Here's the problem: during import of some ops, we look at some of the input arrays to work out some of the configuration.
Example: kH and kW come from shape of input array 1.
This is fine if the arrays are constants, but in some cases (notably, conv1d stuff that uses conv2d internally) the arrays are not constants due to reshaping ops - i.e., conv1d arrays -> reshape -> conv2d op. Thus, we can't actually resolve these properties until runtime - i.e., until partial execution has been completed.
Of course, we can use resolvePropertiesFromSameDiffBeforeExecution(), but that just solves it in java while producing the exact same problem in libnd4j - I want to get rid of that method anyway...
Not sure on the best solution here yet, but in the case of the conv kH/kW ops, we could simply make -1 mean "resolve from array shape in libnd4j"?
We risk running into this any time we use import features like
Aha! Link: https://skymindai.aha.io/features/ND4J-34