Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in org.deeplearning4j.nn.conf.graph.L2NormalizeVertex equals implementation #7225

Closed
LGougerot opened this issue Feb 25, 2019 · 2 comments

Comments

@LGougerot
Copy link

commented Feb 25, 2019

Found on tag 1.0.0-beta3 but appears to be present on more branches.

The equals implem checks for int[] equality with == operator. This should probably be replaced by Arrays.equals.

Furthermore, the hashcode method is constant and ignores both fields of the class. Is this intended ?

Aha! Link: https://skymindai.aha.io/features/DL4J-10

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Yes, both are clearly bugs, thanks for flagging. The equals and hashcode methods should simply be removed; it's suffirient to use the methods generated by the lombok @Data method already on the class.
Feel free to send us a PR if you want - or I'll look to fix it at some point this week.

AlexDBlack added a commit that referenced this issue Mar 18, 2019
[WIP] Various DL4J/ND4J fixes (#7293)
* Evaluation - segmentation support

* ROCBinary and ROCMultiClass segmentation support

* Fixes and EvaluationCalibration segmentation support

* ROC

* #7225 L2NormalizeVertex equals/hashCode fix

* #7268 Fix zeros constructor issue

* #7217 Fix (+ optimize) ConvolutionalIterationListener

* #7292 INDArray.reshape overload - enforce no view

* #7252 Remove Nd4j.emptyLike in favor of Nd4j.zerosLike

* #7277 Switch INDArray.repeat to native op to fix issue

* #7275 Nd4j.meshGrid dtype fix

* Switch Nd4j.tensorMmul to use custom op

* Small fixes

* Small fixes
@lock

This comment has been minimized.

Copy link

commented Apr 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.