Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J: Remove Nd4j.emptyLike #7252

Closed
AlexDBlack opened this issue Mar 6, 2019 · 1 comment

Comments

@AlexDBlack
Copy link
Contributor

commented Mar 6, 2019

https://github.com/deeplearning4j/deeplearning4j/blob/5fe58e75f9b2d6e6741f78901c8eb15ebf2e4c94/nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/factory/Nd4j.java#L5385-L5393

emptyLike is just an alias for zeros/create - but (currently) it doesn't inherit the source datatype.
Given we support empty arrays (which this definitely does not create) it's a misleading method.

Aha! Link: https://skymindai.aha.io/features/ND4J-52

@agibsonccc agibsonccc added the ND4J label Mar 18, 2019

AlexDBlack added a commit that referenced this issue Mar 18, 2019
[WIP] Various DL4J/ND4J fixes (#7293)
* Evaluation - segmentation support

* ROCBinary and ROCMultiClass segmentation support

* Fixes and EvaluationCalibration segmentation support

* ROC

* #7225 L2NormalizeVertex equals/hashCode fix

* #7268 Fix zeros constructor issue

* #7217 Fix (+ optimize) ConvolutionalIterationListener

* #7292 INDArray.reshape overload - enforce no view

* #7252 Remove Nd4j.emptyLike in favor of Nd4j.zerosLike

* #7277 Switch INDArray.repeat to native op to fix issue

* #7275 Nd4j.meshGrid dtype fix

* Switch Nd4j.tensorMmul to use custom op

* Small fixes

* Small fixes
@lock

This comment has been minimized.

Copy link

commented Apr 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.