Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: StackOverflow when calling getArr on scalar valued SDVariables #7546

Closed
treo opened this issue Apr 15, 2019 · 2 comments

Comments

@treo
Copy link

commented Apr 15, 2019

This test fails with a StackOverflow:

    @Test
    public void testSameDiffStackoverflow(){
        final INDArray array = Nd4j.rand(1, 1);
        final SameDiff sd = SameDiff.create();
        final SDVariable a = sd.var("a", array.shape());
        a.setScalarValue(array);
        a.getArr();
    }

@treo treo added Bug SameDiff labels Apr 15, 2019

@AlexDBlack AlexDBlack self-assigned this May 23, 2019

AlexDBlack added a commit that referenced this issue May 25, 2019
SameDiff fixes + improvements; BertWordPieceTokenizer (handle out-of-…
…vocab characters) (#7774)

* Extra overloads for TrainingConfig

* #7678 BERT fixes - control characters etc

* #7678 BERT tokenizer - detect out-of-vocab characters, throw useful exception

* Javadoc/polish

* #7705 SameDiff duplicate name validation

* #7546 SDVariable.getArr scalar issue fix

* SameDiff: add variable renaming

* SameDiff SDVariable renaming javadoc

* Move async iterators to ND4J for use in SameDiff

* Add async iterator support to SameDiff training

* SameDiff listener API

* Base listener, score listener

* Score listener now working

* Fixes and listener polishing

* Small fix
@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Fixed here, and merged to dev branch; will be merged from dev branch to master soon: #7774

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.