Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nd4j: Jackson RowVector(De)Serializer doesn't maintain shape or datatype #7561

Closed
AlexDBlack opened this issue Apr 17, 2019 · 2 comments · Fixed by #7577

Comments

@AlexDBlack
Copy link
Contributor

commented Apr 17, 2019

https://github.com/deeplearning4j/deeplearning4j/tree/master/nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/lossfunctions/serde

This simply hasn't been updated for dtypes and rank 0/1 support.
The only real challenge for fixing this is maintaining backward compatibility.

This is used for weighted loss functions and a few other places.

@AlexDBlack AlexDBlack added the ND4J label Apr 17, 2019

@raver119

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

I've spotted similar ptoblem with Nd4j.writeTxt - we do not store datatype there. Should be fixed as well.

@AlexDBlack AlexDBlack added this to the beta4 release milestone Apr 17, 2019

@AlexDBlack AlexDBlack self-assigned this Apr 18, 2019

AlexDBlack added a commit that referenced this issue Apr 19, 2019
[WIP] More QA and fixes (#7577)
* #7561 Add NDArrayText(De)Serializer to replace RowVector(De)Serializer

* Thorough tests for indexing

* Indexing overhaul, pt1

* Specified index support

* Cleanup

* More cleanup/polish for indexing; more code comments

* Fixes

* Fix + test NDArrayTextSerializer; switch to this for loss function weights + Evaluation

* Weight dtype casts for safety in loss functions

* Small fix

* More tests and final tweaks
@lock

This comment has been minimized.

Copy link

commented May 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.