Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert http -> https for prebuilt models #7779

Closed
tballison opened this issue May 23, 2019 · 3 comments

Comments

@tballison
Copy link

commented May 23, 2019

Issue Description

It looks like the remoteUrl for vgg16_dl4j_inference.zip at least is http, not https: http://blob.deeplearning4j.org/models/vgg16_dl4j_inference.zip

image

Would you be willing to convert http -> https for models and any other remote resources?

Version Information

1.0.0-beta4

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Yes, thanks for flagging.
For the model zoo models, this should be trivial to change - all of the resource URLs are constructed from this base URL:
https://github.com/deeplearning4j/deeplearning4j/blob/master/deeplearning4j/deeplearning4j-common/src/main/java/org/deeplearning4j/common/resources/DL4JResources.java#L47

However a more thorough review (for any other instances of this) would be advisable also.

Note also there's a system property to override that base URL too - that should be a workaround for you, if you want https before waiting for the next release (or switching to snapshots).
https://github.com/deeplearning4j/deeplearning4j/blob/master/deeplearning4j/deeplearning4j-common/src/main/java/org/deeplearning4j/config/DL4JSystemProperties.java#L45-L54

@AlexDBlack AlexDBlack self-assigned this May 28, 2019

AlexDBlack added a commit that referenced this issue May 28, 2019
AlexDBlack added a commit that referenced this issue May 28, 2019
Multiple fixes (#7793)
* #7786 SharedTrainingMaster environment variable fix

* #7785 SameDiffOutputLayer - doInit fix

* #7779 DL4J resources (pretrained models etc) URL: use https

* #7778 Remove DynamicCustomOp.sameDiffBuilder

* Revert #7779

* #7779 Use https resources address that works correctly (certificates match hostname)

* #7754 BaseNDArray.castTo - no-op if already correct type

* Handful of fixes for ND4J sessions tests

* Handful of fixes for ND4J sessions tests

* #7730 Webjars dependencies - lock down versions
@Charele

This comment has been minimized.

Copy link

commented May 30, 2019

I always download them manually by download tool, and put it into homologous folder.

I find it's very very slow if use "FileUtils.copyURLToFile(..." of ZooModel.

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.