Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbiter: EvaluationScoreFunction uses deprecated DL4J Evaluation.Metric (only) not ND4J version #7804

Closed
minutolc opened this issue May 29, 2019 · 4 comments

Comments

@minutolc
Copy link

commented May 29, 2019

Hello ,

I want to implement the example of BasicHyperparameterOptimization but i have some trouble :
When i use OptimizationConfiguration i have to put an scoreFunction and in the tutorial they create it with ScoreFunction scoreFunction = new EvaluationScoreFunction(Evaluation.Metric.ACCURACY);

The problem is that Evaluation.Metric is Deprecated so i have an error when i use it. They advise to use instead ND4J Evaluation class, which has the same interface but i can't find a way to get a scoreFunction with ND4J.

Can someome help me please ?

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Looks like this got missed when Evaluation was moved to ND4J:
https://github.com/deeplearning4j/deeplearning4j/blob/master/arbiter/arbiter-deeplearning4j/src/main/java/org/deeplearning4j/arbiter/scoring/impl/EvaluationScoreFunction.java#L40-L45

The deeplearning4j Evaluation.Metric should still work fine, and give you exactly the same result as the Nd4j Evaluation.Metric.

Thanks for flagging this, we'll make sure to fix this.

@AlexDBlack AlexDBlack changed the title BasicHyperparameterOptimization Example trouble Arbiter: EvaluationScoreFunction uses deprecated DL4J Evaluation.Metric (only) not ND4J version May 29, 2019

@minutolc

This comment has been minimized.

Copy link
Author

commented May 29, 2019

Thank for your quick answer !

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Fixed here, will be merged to master soon: #7807
Thanks for reporting this.

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.