Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL4J: Improve WordVectorSerializer usability #8137

Closed
AlexDBlack opened this issue Aug 23, 2019 · 1 comment

Comments

@AlexDBlack
Copy link
Contributor

commented Aug 23, 2019

There's a number of usability-related improvements we need here

  • No JavaDoc on a lot of methods
  • We should pull methods like readFloat, getFloat, readString etc out into a separate utility method to avoid cluttering the API
  • We need to clearly specify somewhere (class javadoc?) the different formats and methods, and what users should use for different purposes (so they don't need to read through all of the different method javadocs to find what they need)
@alexanderst

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Fixed and merged.

@raver119 raver119 closed this Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.