Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ND4J: Rename org.nd4j.graph.DataType #8159

Closed
AlexDBlack opened this issue Aug 28, 2019 · 0 comments · Fixed by SkymindIO/deeplearning4j#228

Comments

@AlexDBlack
Copy link
Contributor

commented Aug 28, 2019

An easy mistake for users to make is to import the wrong DataType enumeration:

Nd4j.create(DataType.DOUBLE, 10);

Compiles regardless of which import is used, and results in:

  • For org.nd4j.graph.DataType: Default floating point type (float), shape [6,10] (DataType.DOUBLE = 6)
  • For org.nd4j.linalg.api.buffer.DataType, the correct array (double, shape [10])

An additional change we might consider is moving the latter to somewhere like org.nd4j.DataType to make it easier for users to find (the ...linalg.api.buffer part might make it seem like it's an internal thing, for some users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.