Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: Don't allow empty arrays for variables #8209

Closed
AlexDBlack opened this issue Sep 6, 2019 · 0 comments · Fixed by SkymindIO/deeplearning4j#248
Closed

SameDiff: Don't allow empty arrays for variables #8209

AlexDBlack opened this issue Sep 6, 2019 · 0 comments · Fixed by SkymindIO/deeplearning4j#248
Assignees
Labels

Comments

@AlexDBlack
Copy link
Contributor

@AlexDBlack AlexDBlack commented Sep 6, 2019

sd.var("w", DataType.FLOAT, 0, 0, 0) for example will create an empty array due to the 0s in the shape.
This shouldn't be allowed.

@AlexDBlack AlexDBlack self-assigned this Sep 9, 2019
AlexDBlack added a commit to SkymindIO/deeplearning4j that referenced this issue Sep 9, 2019
…r variables

Signed-off-by: AlexDBlack <blacka101@gmail.com>
AlexDBlack added a commit to SkymindIO/deeplearning4j that referenced this issue Sep 9, 2019
* eclipse#8218 Fix Nd4j.hstack rank 1 case

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8209 SameDiff: don't allow empty arrays (with 0s in shape) for variables

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.