Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SameDiff: zero and one names are unclear wrt variable type #8224

Closed
rnett opened this issue Sep 11, 2019 · 0 comments · Fixed by KonduitAI/deeplearning4j#12
Closed

SameDiff: zero and one names are unclear wrt variable type #8224

rnett opened this issue Sep 11, 2019 · 0 comments · Fixed by KonduitAI/deeplearning4j#12

Comments

@rnett
Copy link
Contributor

@rnett rnett commented Sep 11, 2019

The SameDiff zero method creates a zero-initialized variable. It should be made clear that it creates a variable, not a constant. Same for one. Especially as the equivalent Nd4j methods just create constants (no such thing as Nd4j variables).

Imo, it would be best to have oneVar and zeroVar methods, and zero and one constant methods. Another option is specifying that one and zero create variables in their javadocs.

Somewhat related, but a var(String, WeightInitScheme, int...) method should probably exist (the existing versions require a DataType), which may make oneVar and zeroVar unnecessary (the replacement would look like var("name", new ZeroInitScheme('c'), 3, 4).

AlexDBlack added a commit to KonduitAI/deeplearning4j that referenced this issue Oct 24, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
AlexDBlack added a commit to KonduitAI/deeplearning4j that referenced this issue Oct 25, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
AlexDBlack added a commit to KonduitAI/deeplearning4j that referenced this issue Oct 26, 2019
* eclipse#8160 Remove resolvePrepertiesFromSameDiffBeforeExecution

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* SameDiff API cleanup

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* More SameDiff cleanup

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Small fixes

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8248 Switch SameDiff variable init from lazy to creation time for more predictable behaviour

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8252 TanhDerivative javadoc

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8225 Deconvolution2D input validation

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8265 Switch SameDiff.outputs() to user settable, instead of unreliable 'best guess'

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8224 SameDiff.zero and .one create constants, not variables

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* More cleanup and fixes

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Small test fix

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Small fix

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* DL4J SameDiff fixes

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Re-add hack for Deconvolution2DLayer until eclipse#8315 is resolved

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8270 Move CUDA device/version logging to Java; can be disabled via existing org.nd4j.log.initialization system property

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* All ND4J init logging checks system property

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Small tweak

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Remove redundant device logging

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* One more fix

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* UX improvements

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Deconv fix

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Add deconv tests

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Cleanup

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Remove debug code

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.