Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnd4j: concat op - add "last input is axis" support #8285

Closed
AlexDBlack opened this issue Oct 12, 2019 · 1 comment · Fixed by KonduitAI/deeplearning4j#28
Closed

libnd4j: concat op - add "last input is axis" support #8285

AlexDBlack opened this issue Oct 12, 2019 · 1 comment · Fixed by KonduitAI/deeplearning4j#28
Labels

Comments

@AlexDBlack
Copy link
Contributor

@AlexDBlack AlexDBlack commented Oct 12, 2019

Required for TF import.
Currently we pull out the axis during import, which will work most of the time, but will fail if axis is ever dynamic. Also modifying graph structure (to remove input from an op) during op import isn't exactly a clean design...

Here's an example TF node in graph, note the last input:

node {
  name: "output"
  op: "ConcatV2"
  input: "Variable/read"
  input: "Variable_1/read"
  input: "Variable_2/read"
  input: "Variable_3/read"
  input: "output/axis"
  attr {
    key: "N"
    value {
      i: 4
    }
  }
  attr {
    key: "T"
    value {
      type: DT_FLOAT
    }
  }
  attr {
    key: "Tidx"
    value {
      type: DT_INT32
    }
  }
}
@shyrma

This comment has been minimized.

Copy link
Contributor

@shyrma shyrma commented Nov 3, 2019

added!

AlexDBlack added a commit to KonduitAI/deeplearning4j that referenced this issue Nov 4, 2019
Signed-off-by: AlexDBlack <blacka101@gmail.com>
@AlexDBlack AlexDBlack mentioned this issue Nov 4, 2019
AlexDBlack added a commit to KonduitAI/deeplearning4j that referenced this issue Nov 4, 2019
* eclipse#8280 biasadd_bp nchw arg fixes (java side) + test

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* eclipse#8285 Concat op Java side fixes

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* Concat op cpp fix - allow dynamic axis to be negative, same as static axis

Signed-off-by: AlexDBlack <blacka101@gmail.com>

* ignores for deconv3d import tests until deconv3d_tf op is implemented

Signed-off-by: AlexDBlack <blacka101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.