New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "no bias" layers #3882
Conversation
I tried searching for papers on the importance of this and was not able to find anything. Bias is not a particular discriminating search pattern for papers on this. Can you answer some quick questions at some point before or after this is merged so I can see that some documentation is written.
No need for burdensome research just a quick brain dump would help. Thanks |
@tomthetrainer I haven't really seen anything in the literature on "no bias" layers. For most users (99% of the time) they will use layers with biases (which is the default). The only exception there is embedding layer (which now defaults to noBias = true) which is more in line with how word2vec operates. The main reason we are adding this is for model import support from Keras. |
@AlexDBlack it's not all that important, but I would vote for quickly refactoring |
@maxpumperla yeah, that thought did cross my mind. I was on the fence about that when implementing it. I'll switch to |
I've switched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should be good to go as-is.
Adds a
.hasBias(boolean)
config option (default: true, though false for embedding) for the following layers:Of note: