Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log information proposing to use cuDNN when appropriate #4039

Merged
merged 2 commits into from Sep 15, 2017

Conversation

@saudet
Copy link
Member

commented Sep 11, 2017

Fixes #3868

What changes were proposed in this pull request?

Logs information to suggest using cuDNN when appropriate and the page where to find more information. The output is displayed only once, but once for each layer...

How was this patch tested?

Running an example with CUDA, but without cuDNN, displays the information, without stopping execution.

@saudet saudet requested a review from AlexDBlack Sep 11, 2017

@AlexDBlack
Copy link
Contributor

left a comment

The idea is great - but I'm wondering if we use the one-time logger to avoid too many log message? I think currently this will be one per layer, which could be a lot for big nets.
https://github.com/deeplearning4j/deeplearning4j/search?utf8=%E2%9C%93&q=OneTimeLogger+in%3Apath&type=

I also might tweak the message slightly, for those who don't yet know what cudnn is (or why they should care) -
"cuDNN not found: use cuDNN for better GPU performance by including the deeplearning4j-cuda module. " + ...

@huitseeker

This comment has been minimized.

Copy link

commented Sep 14, 2017

This could use a rebase, but otherwise looks dope!

@saudet saudet force-pushed the sa_cudnn branch from 0a81f09 to 87e8fac Sep 14, 2017

@saudet

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2017

Rebased!

@huitseeker
Copy link

left a comment

👍

changes done in 87e8fac

@huitseeker huitseeker merged commit 45db8d2 into master Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.