Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
NearestNeighboursServer logging improvements #4272
huitseeker left a comment
The logging LGTM.
And it really doesn't have a lot of uncommented content:
Is there any way we could point the server test to another application.conf with something like
Or at least make this file minimal, to clearly communicate this is a test stub?
Hm, though if application.conf and logback.xml for test resources are defined in relative terms, they won't be on the classpath (which, alone, won't be sufficient). I agree with the motivation to reduce duplication though... I think our best option might be to:
(a) Have a single copy in say deeplearning4j-core or -nn (unless somewhere else would be better?)
(b) Configure maven surefure plugin to set relevant system properties for each library that requires them