Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set play crypto secret #4289

Merged
merged 2 commits into from Nov 13, 2017

Conversation

@AlexDBlack
Copy link
Contributor

commented Nov 13, 2017

Fixes: #4277

Sets play secret dynamically. Users can override by setting system property.

@AlexDBlack AlexDBlack requested a review from wmeddie Nov 13, 2017

@wmeddie
Copy link

left a comment

LGTM. This is a good and secure default for our purposes.

@AlexDBlack AlexDBlack changed the title Set play crypto secret, in application.conf Set play crypto secret Nov 13, 2017

@AlexDBlack AlexDBlack merged commit dc361db into master Nov 13, 2017

@AlexDBlack AlexDBlack deleted the ab_4277_playsecret branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.