Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4302: Initialize workspace in computeGradientAndScore #4320

Merged
merged 2 commits into from Nov 22, 2017

Conversation

@AlexDBlack
Copy link
Contributor

commented Nov 21, 2017

Fixes: #4302

@AlexDBlack AlexDBlack requested a review from raver119 Nov 21, 2017

@raver119

This comment has been minimized.

Copy link
Contributor

commented Nov 22, 2017

Yes it fails, and that's fine. I'll pm.

@raver119
Copy link
Contributor

left a comment

Looks great.

@AlexDBlack AlexDBlack merged commit cf58c14 into master Nov 22, 2017

1 check was pending

codeclimate Code Climate is analyzing this code.
Details

@AlexDBlack AlexDBlack deleted the ab_4302_scope branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.