Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace + preprocessor fixes #4349

Merged
merged 9 commits into from Nov 30, 2017

Conversation

@AlexDBlack
Copy link
Contributor

commented Nov 30, 2017

Fixes: #4347 which was due to preprocessors (that allocate new arrays) having arrays in the wrong workspaces, due to preprocessor execution in LayerVertex being done in LayerVertex.setInput.
Also fixed another workspace issue in MultiLayerNetwork.

@raver119
Copy link
Contributor

left a comment

Looks good, as discussed in gitter.

@raver119
Copy link
Contributor

left a comment

Still good :)

@raver119
Copy link
Contributor

left a comment

I'd keep this as test tbh. Bug took so much time, so it would be nice to ensure we won't hit into it again.

@AlexDBlack AlexDBlack merged commit 71cc4a8 into master Nov 30, 2017

1 check failed

codeclimate 2 issues to fix
Details

@AlexDBlack AlexDBlack deleted the ab_4347 branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.