Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace + preprocessor fixes #4349

Merged
merged 9 commits into from Nov 30, 2017
Merged

Workspace + preprocessor fixes #4349

merged 9 commits into from Nov 30, 2017

Conversation

AlexDBlack
Copy link
Contributor

Fixes: #4347 which was due to preprocessors (that allocate new arrays) having arrays in the wrong workspaces, due to preprocessor execution in LayerVertex being done in LayerVertex.setInput.
Also fixed another workspace issue in MultiLayerNetwork.

@AlexDBlack AlexDBlack mentioned this pull request Nov 30, 2017
Closed
raver119
raver119 previously approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@raver119 raver119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as discussed in gitter.

raver119
raver119 previously approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@raver119 raver119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good :)

raver119
raver119 approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@raver119 raver119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this as test tbh. Bug took so much time, so it would be nice to ensure we won't hit into it again.

@AlexDBlack AlexDBlack merged commit 71cc4a8 into master Nov 30, 2017
@AlexDBlack AlexDBlack deleted the ab_4347 branch November 30, 2017 09:13
@AlexDBlack AlexDBlack mentioned this pull request Nov 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raver119 raver119 raver119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feedForward produces non-deterministic output in inference mode.
2 participants
@AlexDBlack @raver119