Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RNN evaluation more memory efficient when using TBPTT #4405

Merged
merged 7 commits into from Dec 17, 2017

Conversation

@AlexDBlack
Copy link
Contributor

commented Dec 13, 2017

Addresses: #3482

@AlexDBlack AlexDBlack requested a review from raver119 Dec 13, 2017

@AlexDBlack AlexDBlack force-pushed the ab_3482_tbptt_eval branch from 536d107 to e0b8f1c Dec 14, 2017

@raver119
Copy link
Contributor

left a comment

Generally looks great.
Have you checked what happens after multiple training->evaluation cycles? Does memory use stay stable?

@AlexDBlack AlexDBlack merged commit c06924b into master Dec 17, 2017

1 check failed

codeclimate 6 issues to fix
Details

@AlexDBlack AlexDBlack deleted the ab_3482_tbptt_eval branch Dec 17, 2017

@AlexDBlack

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2017

@raver119 thanks, and not yet. I'll run some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.