Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lombok artifact provided in pom.xml files #4847

Merged
merged 1 commit into from Mar 27, 2018

Conversation

@saudet
Copy link
Member

commented Mar 27, 2018

Fixes #4839

What changes were proposed in this pull request?

Prevent Lombok from leaking to dependent projects, update version, and rearrange dependencies as required because no longer transitive.

How was this patch tested?

Build passes, running LenetMnistExample from dl4j-examples works, and confirmed manually on it that mvn dependency:tree does not contain lombok anymore.

@saudet saudet requested a review from AlexDBlack Mar 27, 2018

@AlexDBlack AlexDBlack merged commit 73532ad into master Mar 27, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexDBlack AlexDBlack deleted the sa_maven branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.