Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGG offset values are wrong (listed in RGB order) #6254

Merged
merged 3 commits into from Aug 27, 2018

Conversation

@monktastic
Copy link

commented Aug 23, 2018

No description provided.

monktastic added 2 commits Aug 23, 2018
@monktastic

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

Not familiar with the project build yet. Not sure why it's failing.

@AlexDBlack
Copy link
Contributor

left a comment

LGTM, I checked and I double checked that (a) NativeImageLoader is producing BGR output, and (b) the now corrected values are the correct values in BGR order

@AlexDBlack AlexDBlack merged commit 57ccb33 into eclipse:master Aug 27, 2018

0 of 2 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.