Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use US Locale when formatting numbers with NDArrayStrings #6537

Merged
merged 2 commits into from Oct 5, 2018

Conversation

@treo
Copy link

commented Oct 5, 2018

On Systems with a locale where a , is used as a decimal separator the problem arises where Nd4j.writeTxt produces invalid JSON.

This PR changes it so always US is used as the locale when formatting arrays.

@treo treo requested a review from AlexDBlack Oct 5, 2018

@AlexDBlack
Copy link
Contributor

left a comment

LGTM 👍

@AlexDBlack AlexDBlack merged commit 1f3ea96 into master Oct 5, 2018

0 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details

@AlexDBlack AlexDBlack deleted the treo_decimal_seperator_in_ndarraystrings branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.