Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layerConf() public #6553

Merged
merged 1 commit into from Oct 10, 2018

Conversation

@timmolter
Copy link

commented Oct 10, 2018

In order to get layer configuration parameters like kernelSize, stride, etc for SubsamplingLayer and any others that directly extend AbstractLayer, this method should be public. For cases like ConvolutionLayer that extend BaseLayer layerConf() is already public.

@AlexDBlack
Copy link
Contributor

left a comment

Sure, I see no harm in this. LGTM 👍

@AlexDBlack AlexDBlack merged commit 2243fca into eclipse:master Oct 10, 2018

1 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@timmolter

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

Cheers, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.