Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to just released JavaCPP and JavaCV 1.4.3 #6587

Merged
merged 1 commit into from Oct 15, 2018

Conversation

@saudet
Copy link
Member

commented Oct 15, 2018

Also switch to CUDA 10.0 by default.

@saudet saudet requested a review from AlexDBlack Oct 15, 2018

@AlexDBlack
Copy link
Contributor

left a comment

LGTM. Not sure if the switch to CUDA 10 was intentional (but I'm fine with it)

@AlexDBlack AlexDBlack force-pushed the sa_javacpp branch from a83dd30 to 2f67d09 Oct 15, 2018

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

I was seeing a number of CI failures, unrelated: #6591
Only one of concern was linux x86 libnd4j build... that crashed for some reason.
I've re-triggered CI, and I've checked local linux build (runs fine) so linux x86 failure is probably an anomaly, but I'd like to confirm that before merging.

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

nd4j-native seems fine on this 2nd run, I'll merge this.

@AlexDBlack AlexDBlack merged commit 4048757 into master Oct 15, 2018

1 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@agibsonccc agibsonccc deleted the sa_javacpp branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.