Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigating ZipSlip vulnerability #6630

Merged
merged 2 commits into from Oct 24, 2018

Conversation

@conikeec
Copy link

commented Oct 23, 2018

patched org/nd4j/util/ArchiveUtils.java to mitigate ZipSlip vulnerability (https://nakedsecurity.sophos.com/2018/06/06/the-zip-slip-vulnerability-what-you-need-to-know/)

@agibsonccc
Copy link

left a comment

Minor nitpick on logging.

@conikeec

This comment has been minimized.

Copy link
Author

commented Oct 24, 2018

Changes applied (log nitpick suggestion)

@agibsonccc

This comment has been minimized.

Copy link

commented Oct 24, 2018

If that's how you want to do it. I thought you wanted to add the target dir as a log message. Thanks for the fix!

@agibsonccc agibsonccc merged commit f51f424 into eclipse:master Oct 24, 2018

0 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.