Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix incorrect batch sizes in KFoldIterator #6810
What changes were proposed in this pull request?
Visibility of private fields and methods in
An unneccessary copy of the
Unit tests has been modified too: enhancements, improved documentation comments, and an added new test case.
How was this patch tested?
Manual test run in the directory
This needs to be in the source code comments too.
The 2nd file we should modify in this PR is the KFoldIteratorTest.java.
btw: I literally just did the KFoldIterator Example which was an open ticket since february.
Finally, I updated
RobAltena left a comment •
I have just the one tiny issue with the PR. But am struggling with my local dev environment.
I could build nd4j locally and make sure the tests pass. When I then fetch in this pull request and run the tests I get an error:
That must have run the tests against the old version. I tried this again and this time the old tests passed on the old version and the new tests passed on the new version. So we just have the one typo in the comments to fix.