Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringToTimeTransform support i18n & arbiter ui dropout ParameterSpace json convert exception #6901

Merged
merged 7 commits into from Dec 21, 2018

Conversation

@coolbeevip
Copy link

commented Dec 19, 2018

What changes were proposed in this pull request?

I add java.util.Local parameter to stringToTimeTransform method and StringToTimeTransform constructor for i18n
fix #6825

add @NoArgsConstructor to org.deeplearning4j.arbiter.conf.dropout.DropoutSpace.java
fix #6879

How was this patch tested?

manual tests

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files).
OneITOM and others added 7 commits Dec 19, 2018
I add java.util.Local paramter to stringToTimeTransform method and St…
…ringToTimeTransform constructor for i18n
@AlexDBlack
Copy link
Contributor

left a comment

Looks good to me - thanks for the PR! :)

@AlexDBlack AlexDBlack merged commit f2a7616 into eclipse:master Dec 21, 2018

1 of 3 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
printomi added a commit to printomi/deeplearning4j that referenced this pull request Jan 7, 2019
StringToTimeTransform support i18n & arbiter ui dropout ParameterSpac…
…e json convert exception (eclipse#6901)

* I add java.util.Local paramter to stringToTimeTransform method and StringToTimeTransform constructor for i18n

* I add java.util.Local paramter to stringToTimeTransform method and StringToTimeTransform constructor for i18n

* I add java.util.Local paramter to stringToTimeTransform method and StringToTimeTransform constructor for i18n

* add @NoArgsConstructor

* add @NoArgsConstructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.