Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing calculate FAR for the EvaluationBinary #7320

Merged
merged 8 commits into from Mar 21, 2019

Conversation

@dariuszzbyrad
Copy link

commented Mar 20, 2019

What changes were proposed in this pull request?

  1. Added calculate False Alarm Rate (FAR) for the EvaluationBinary class.
  2. Added scoreForMetric method for the EvaluationBinary class (something like that org.nd4j.evaluation.classification.Evaluation#scoreForMetric).
  3. Added one missing javadoc for the org.nd4j.evaluation.classification.EvaluationBinary#merge

How was this patch tested?

Updated existing unit test.

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files).
Merge pull request #1 from deeplearning4j/master
Merged changes from original repository
@AlexDBlack
Copy link
Contributor

left a comment

LGTM, thanks again!

@AlexDBlack AlexDBlack merged commit c57f437 into eclipse:master Mar 21, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.