Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComputationGraph] Calculate topologicalOrder if its null when summary is called #7353

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@rnett
Copy link
Contributor

commented Mar 26, 2019

What changes were proposed in this pull request?

Fixes #7350. If summary() is called before init() it will calculate topologicalOrder().

How was this patch tested?

N/A

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions.
  • Relevant tests for your changes are passing.
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files).
@AlexDBlack
Copy link
Contributor

left a comment

LGTM, thanks again!

@AlexDBlack AlexDBlack merged commit a092919 into eclipse:master Mar 27, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.