Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up more third-party content: FlatBuffers, RandomUtils.java, and StringUtils.java #7487

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@saudet
Copy link
Member

commented Apr 9, 2019

For issue #6907

What changes were proposed in this pull request?

To reduce paperwork for the Eclipse Foundation download FlatBuffers at build time, and use alternatives for RandomUtils.java and StringUtils.java

How was this patch tested?

Everything compiles and all unit tests for libnd4j pass, leaving the rest to the CI server...

@saudet saudet requested review from AlexDBlack and raver119 Apr 9, 2019

@AlexDBlack
Copy link
Contributor

left a comment

I haven't run tests, but changes LGTM 👍

@saudet saudet merged commit 1cf7ae5 into master Apr 9, 2019

0 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details

@raver119 raver119 deleted the sa_eclipse branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.