Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result shape datatype calculation for Variance based Ops #7699

Merged
merged 2 commits into from May 9, 2019

Conversation

@treo
Copy link

commented May 9, 2019

Fixes #7697

And also fixes wrong use of DataType in previously ignored test that passes now.

@treo treo requested a review from AlexDBlack May 9, 2019

@AlexDBlack
Copy link
Contributor

left a comment

In future this should go on dev branch, but given we're fixing master bugs currently, master is OK...

@AlexDBlack AlexDBlack merged commit 1342dcd into master May 9, 2019

1 check was pending

continuous-integration/jenkins/pr-head This commit has test failures
Details

@AlexDBlack AlexDBlack deleted the treo/issue_7697 branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.