Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Yolo2OutputLayer builder method name - rename lambbaNoObj… #7728

Merged
merged 1 commit into from May 14, 2019

Conversation

@KrzysztofKarol
Copy link

commented May 13, 2019

… to lambdaNoObj

What changes were proposed in this pull request?

Fix typo in Yolo2OutputLayer builder method name

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

Quick checklist

The following checklist helps ensure your PR is complete:

  • Reviewed the Contributing Guidelines and followed the steps within.
  • Created tests for any significant new code additions. (N/A)
  • Relevant tests for your changes are passing. (Tried to run integration tests but couldn't configure properly - does CI run it?)
  • Ran mvn formatter:format (see formatter instructions for targeting your specific files). (Could not run but formatting was preserved)

Question

Do we allow breaking changes or this method should be deprecated first?

/**
 * Loss function coefficient for the "no object confidence" components of the loss function. Default (as per
 * paper): 0.5
 *
 * @param lambdaNoObj Lambda value for no-object (confidence) component of the loss function
 */
public Builder lambdaNoObj(double lambdaNoObj) {
    this.setLambdaNoObj(lambdaNoObj);
    return this;
}

/**
 * Loss function coefficient for the "no object confidence" components of the loss function. Default (as per
 * paper): 0.5
 *
 * @deprecated Use {@link #lambdaNoObj(double)} instead.
 *
 * @param lambdaNoObj Lambda value for no-object (confidence) component of the loss function
 */
@Deprecated
public Builder lambbaNoObj(double lambdaNoObj) {
    this.setLambdaNoObj(lambdaNoObj);
    return this;
}
@AlexDBlack
Copy link
Contributor

left a comment

LGTM, thanks for the PR 👍

@AlexDBlack AlexDBlack merged commit a21a1e5 into eclipse:master May 14, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.