Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ComputationGraphConfiguration.GraphBuilder.setInputTypes validation #7752

Merged
merged 1 commit into from May 18, 2019

Conversation

@cpoerschke
Copy link

commented May 17, 2019

What changes were proposed in this pull request?

for #7750 issue

How was this patch tested?

cd deeplearning4j/deeplearning4j-core
mvn test -Dtest=ComputationGraphConfigurationTest

//Test: input != inputType count mismatch
try {
new NeuralNetConfiguration.Builder().graphBuilder().addInputs("input1", "input2")

This comment has been minimized.

Copy link
@cpoerschke

cpoerschke May 17, 2019

Author

This configuration is almost the same as testJSONWithGraphNodes() but likely could be trimmed to be shorter?

@cpoerschke

This comment has been minimized.

Copy link
Author

commented May 17, 2019

full disclosure: i encountered local build issues and the test did not successfully run but gave the following error:

  Run 1: ComputationGraphConfigurationTest>BaseDL4JTest.beforeTest:54 » NoClassDefFound
  Run 2: ComputationGraphConfigurationTest>BaseDL4JTest.afterTest:62 » NoClassDefFound ...
@AlexDBlack
Copy link
Contributor

left a comment

LGTM, thanks! 👍
Test configuration could be shorter, yes... not a big deal though.

Edit: as for test issues - probably something locally on your machine, not sure what.
Though we do have a bunch of issues to clean up on master currently anyway... #7657
Thanks for mentioning it though.

@AlexDBlack AlexDBlack merged commit 709f5e0 into eclipse:master May 18, 2019

0 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/jenkins/pr-head This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.