Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataVec: Avoid sampling bias in RandomPathFilter.filter() #7769

Merged
merged 2 commits into from May 21, 2019

Conversation

@saudet
Copy link
Member

commented May 21, 2019

Fixes #7738

@AlexDBlack Is there already a set of images somewhere in the test resources that we could use to create a test for this?

What changes were proposed in this pull request?

Shuffles the input array before filtering to avoid sampling bias.

How was this patch tested?

Existing unit tests pass

@saudet saudet requested a review from AlexDBlack May 21, 2019

@AlexDBlack

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@saudet We have a few (very) small sets of images here: https://github.com/deeplearning4j/dl4j-test-resources/tree/master/src/main/resources/datavec-data-image

But we could duplicate the files a few times in the tests themselves...

Anyway, changes LGTM...

@saudet saudet merged commit 73f93ef into dev_20190513 May 21, 2019

0 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details

@raver119 raver119 deleted the sa_image branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.