Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RL4J: Fix HistoryProcessor now using castTo() to perform "compression" #7819

Merged
merged 1 commit into from May 31, 2019

Conversation

@saudet
Copy link
Member

commented May 31, 2019

Fixes #7806

What changes were proposed in this pull request?

ND4J has deprecated NDArray "compression" in favor of casting to different DataType, so we need to change this in RL4J as well.

How was this patch tested?

Added a new unit test that fails without this change.

@saudet saudet requested a review from AlexDBlack May 31, 2019

@AlexDBlack
Copy link
Contributor

left a comment

I haven't tested, but LGTM

@saudet saudet merged commit 335b219 into dev_20190513 May 31, 2019

0 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details

@raver119 raver119 deleted the sa_rl4j branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.