Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
RL4J Added IDataManager #8034
What changes were proposed in this pull request?
Classes in RL4J directly uses the implementation of DataManager. In this PR, I add an interface (IDataManager) and made changes to a few classes in order to use this interface instead of DataManager.
What I have in mind (in an upcoming PR) is to remove DataManager as a dependency and use a listener pattern in the classes that currently uses DataManager. This way we move a bit closer to the single responsibility principle and there will be a generic way to listen to the beginning and end of training epochs.
The goal of this PR is to add unit tests to AsyncThread and SyncLearning to be sure that I don't break anything when I add the listener pattern. Also, I added an interface to AsyncGlobal to be able to create these unit tests.
Summary of changes:
How was this patch tested?
Unit tests to AsyncThread and SyncLearning
The following checklist helps ensure your PR is complete: