[fix]: bugfix choice(INDArray source, INDArray probs, int numSamples) #9360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raymondlam looks good! Do you mind signing the eclipse ECA? See more here: https://deeplearning4j.konduit.ai/getting-started/contribute/eclipse-contributors |
Signed-off-by: Romira915 <40430090+Romira915@users.noreply.github.com>
|
The signature seems to have been processed correctly. Thank you. |
agibsonccc
approved these changes
Jun 10, 2021
|
Merged, great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug that occurred when using the
choice(INDArray source, INDArray probs, int numSamples)function (For example, when you declare anINDArraywith double type.) because the data type ofsourcewas not taken into account.