Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nginx connectivity after Helm update #375

Merged
merged 3 commits into from Apr 12, 2019

Conversation

@kaizimmerm
Copy link
Member

commented Apr 5, 2019

Hi,

I fixed an issue where the reverse proxy was no longer able the access the gateway after a (pod) update. The reason was that no ClusterIP was used and the pod IP changed as a result of the update.

In addition I improved the boolean flag for MongoDB SSL a bit, introduced replicaCount as a setting for the pods, a version setting for Swagger-UI and added a few missing labels.

Kai

kaizimmerm added 2 commits Apr 4, 2019
Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>
Signed-off-by: Kai Zimmermann <kai.zimmermann@microsoft.com>
@kaizimmerm kaizimmerm force-pushed the kaizimmerm:fix-nginx-connectivity branch from c19e0b6 to 7db4562 Apr 5, 2019
@kaizimmerm

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2019

I apologise but I had to change a detail (MongoDB uri secret) in the PR after opening it. Did not work always the way it was.

…zimmermann@microsoft.com>
@kaizimmerm kaizimmerm force-pushed the kaizimmerm:fix-nginx-connectivity branch from 7db4562 to a5993d5 Apr 5, 2019
@ghandim

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@kaizimmerm Will give it a try 😄

@ghandim

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@kaizimmerm LGTM 👍 . But I would also suggest to add the gateway cluster endpoint in nginx.conf as upstream, than developers can also re-deploy the gateway without the necessity to restart nginx.

...
  upstream gateway {
    server  gateway:8080;
  }

  server {
...
 proxy_pass                    http://gateway/api; // switch for all gateway proxy_pass configured in nginx.conf

What do you think?

@kaizimmerm

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

@ghandim sounds great. However, I will be on vacation for the next two weeks. So either you wait until then or merge and do it yourself. I am open to follow either way.

kai

@ghandim

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@thjaeckle LGTM 👍 I will prepare a separate pull request for the nginx configuration improvement.

@thjaeckle thjaeckle merged commit 9920280 into eclipse:master Apr 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@thjaeckle thjaeckle added this to the 0.9.0-M2 milestone Apr 12, 2019
@kaizimmerm kaizimmerm deleted the kaizimmerm:fix-nginx-connectivity branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.