Implement RichIterable.groupByAndCollect().

[nikhilnanivadekar]

Refer to discussion on pull request 37 for more information. Also, please use the most up-to-date name decided.

[motlin]

Full signature:

public <K, V> Multimap<K, V> groupByAndCollect(
    Function<? super T, ? extends K> groupByFunction,
    Function<? super T, ? extends V> collectFunction)

[TheLoneKing]

I am trying to implement groupByAndCollect method on RichIterable. My test is failing with errors that looks confusing.
Here are some errors:

1. [ERROR] ImmutableSortedBagImplTest.RichIterable_groupByAndCollect expected: org.eclipse.collections.impl.map.mutable.UnifiedMap<{false=[12, 10, 8, 6, 4], true=[11, 9, 7, 5, 3]}> but was: org.eclipse.collections.impl.map.mutable.UnifiedMap<{false=[12, 10, 8, 6, 4], true=[11, 9, 7, 5, 3]}>
2. [ERROR] ImmutableHashBiMapInverseTest.RichIterable_groupByAndCollect expected:<{false=[8, 10, 12, 4, 6], true=[9, 11, 3, 5, 7]}> but was:<{false=[4, 6, 8, 10, 12], true=[3, 5, 7, 9, 11]}>

In case 1, both expected result and the actual result are same. But the test is still failing as if they were different.
In case 2, just the order of the elements in the collection is different. I am not sure why the test is failing because of that.
Here is my implementation and test case: TheLoneKing@8f0025f
Can someone help on how to fix the failing tests?

[motlin]

That output doesn’t mean that the expected and actual were the same, just that their toString() representations are the same. I’m guessing one is a map of lists and one is a map of sets.

…

On Mon, Jul 22, 2019 at 9:38 PM Dineshkumar Gnanaprakasam < ***@***.***> wrote: I am trying to implement groupByAndCollect method on RichIterable. My test is failing with errors that looks confusing. Here are some errors: 1. [ERROR] ImmutableSortedBagImplTest.RichIterable_groupByAndCollect expected: org.eclipse.collections.impl.map.mutable.UnifiedMap<{false=[12, 10, 8, 6, 4], true=[11, 9, 7, 5, 3]}> but was: org.eclipse.collections.impl.map.mutable.UnifiedMap<{false=[12, 10, 8, 6, 4], true=[11, 9, 7, 5, 3]}> 2. [ERROR] ImmutableHashBiMapInverseTest.RichIterable_groupByAndCollect expected:<{false=[8, 10, 12, 4, 6], true=[9, 11, 3, 5, 7]}> but was:<{false=[4, 6, 8, 10, 12], true=[3, 5, 7, 9, 11]}> In case 1, both expected result and the actual result are same. But the test is still failing as if they were different. In case 2, just the order of the elements in the collection is different. I am not sure why the test is failing because of that. Here is my implementation and test case: ***@***.*** <TheLoneKing@8f0025f> Can someone help on how to fix the failing tests? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=AAB3UIRSGQK6PS5FOQ6VQZLQAZOKXA5CNFSM4B22VGCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2RUZTY#issuecomment-514018511>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB3UISJW5UAG3BY7QG5W7DQAZOKXANCNFSM4B22VGCA> .