Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eclipse issues with MANIFEST.MF #49

Closed
elius1 opened this issue Feb 10, 2016 · 2 comments
Closed

Eclipse issues with MANIFEST.MF #49

elius1 opened this issue Feb 10, 2016 · 2 comments

Comments

@elius1
Copy link

elius1 commented Feb 10, 2016

Eclipse is able to pick up the eclipse-collections-api jar as a plug-in. However, the eclipse-collections jar is not recognized as such.

Also, for both jars, the exported packages list only contains the top level package. This causes Eclipse to recognize the classes in all subpackages as non-api, resulting in warnings when used.

Could this be an issue with the way that the MANIFEST.MF files in the jars are build?

@motlin
Copy link
Contributor

motlin commented Feb 10, 2016

The MANIFEST.MF is created by the maven-bundle-plugin. Here are the relevant portions of the pom files.

https://github.com/eclipse/eclipse-collections/blob/master/eclipse-collections-api/pom.xml#L76
https://github.com/eclipse/eclipse-collections/blob/master/eclipse-collections/pom.xml#L82

Is the fix as simple as replacing the import...

<Export-Package>org.eclipse.collections.impl</Export-Package>

...with a star import?

<Export-Package>org.eclipse.collections.impl.*</Export-Package>

@stfnsche
Copy link

In https://github.com/eclipse/eclipse-collections/blob/master/eclipse-collections-api/pom.xml you need not specify any Export-Package (default behaviour is to export all packages except those containing internal or impl).
In https://github.com/eclipse/eclipse-collections/blob/master/eclipse-collections/pom.xml you need to specify everything you want exported (as the packages contain impl in their name). To export everything you can write as you said
<Export-Package>org.eclipse.collections.impl.*</Export-Package>

@motlin motlin added the bug label May 20, 2016
@motlin motlin closed this as completed in d1d4b40 Nov 19, 2016
motlin added a commit that referenced this issue Nov 19, 2016
Fix Eclipse issues with MANIFEST.MF Fixes #49.
nikhilnanivadekar referenced this issue in nikhilnanivadekar/eclipse-collections Dec 24, 2016
itohro pushed a commit to itohro/eclipse-collections that referenced this issue Mar 7, 2017
itohro pushed a commit to itohro/eclipse-collections that referenced this issue Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants