Implement union operation on primitive sets. Partially addresses issue #310. #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donraab
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Hi @prathasirisha, thank you for the contribution. It mostly looks good. I've just requested a few extra test scenarios for empty sets.
...code-generator/src/main/resources/test/set/mutable/abstractImmutablePrimitiveSetTestCase.stg
Show resolved
Hide resolved
...lections-code-generator/src/main/resources/test/set/mutable/abstractPrimitiveSetTestCase.stg
Show resolved
Hide resolved
...rc/test/java/org/eclipse/collections/impl/set/mutable/primitive/AbstractByteSetTestCase.java
Show resolved
Hide resolved
...org/eclipse/collections/impl/set/mutable/primitive/AbstractImmutableByteHashSetTestCase.java
Show resolved
Hide resolved
mohrezaei
requested changes
Oct 8, 2020
eclipse-collections-code-generator/src/main/resources/api/set/immutablePrimitiveSet.stg
Outdated
Show resolved
Hide resolved
eclipse-collections-code-generator/src/main/resources/api/set/mutablePrimitiveSet.stg
Outdated
Show resolved
Hide resolved
|
We need another API which takes a target set. |
mohrezaei
approved these changes
Oct 9, 2020
Hi @nikhilnanivadekar, I think we can add the methods which take target collections in a separate PR. |
…eclipse#310. Signed-off-by: Sirisha Pratha <sirisha.pratha@bnymellon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sirisha Pratha sirisha.pratha@bnymellon.com