New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Type Hierarchy #28

Open
guw opened this Issue Jul 6, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@guw

guw commented Jul 6, 2016

Probably needs extension of the protocol as well as in VScode?

@gorkem gorkem added the enhancement label Aug 2, 2016

@gorkem

This comment has been minimized.

Show comment
Hide comment
@gorkem

gorkem Nov 26, 2016

Member

See Microsoft/language-server-protocol#136 for protocol discussions

Member

gorkem commented Nov 26, 2016

See Microsoft/language-server-protocol#136 for protocol discussions

yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this issue Jul 4, 2017

Fix eclipse#28 add option to set the JDK home directory, from which t…
…o run the JLS

Signed-off-by: Fred Bricon <fbricon@gmail.com>

fbricon pushed a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 21, 2017

Merge pull request eclipse#28 from ansyral/imple
add jdt language server info provider implementation
@Yanpas

This comment has been minimized.

Show comment
Hide comment
@Yanpas

Yanpas Sep 26, 2018

Isn't this functionality already implemented is Eclipse? The only thing left to do is to expose LSP-RPC method.

Yanpas commented Sep 26, 2018

Isn't this functionality already implemented is Eclipse? The only thing left to do is to expose LSP-RPC method.

@fbricon

This comment has been minimized.

Show comment
Hide comment
@fbricon

fbricon Sep 26, 2018

Contributor

It needs to be rewritten to decouple it from JDT UI. So, once we have standardized the protocol, then we'll refactor eclipse's internals for jdt.ls to conform to it

Contributor

fbricon commented Sep 26, 2018

It needs to be rewritten to decouple it from JDT UI. So, once we have standardized the protocol, then we'll refactor eclipse's internals for jdt.ls to conform to it

@Yanpas

This comment has been minimized.

Show comment
Hide comment
@Yanpas

Yanpas Sep 26, 2018

You may implement it as cquery project did as protocol extension and then rename this method. The LSP proposal is already 2 years old and seems will be accepted only when vs code developers need it.

Yanpas commented Sep 26, 2018

You may implement it as cquery project did as protocol extension and then rename this method. The LSP proposal is already 2 years old and seems will be accepted only when vs code developers need it.

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 2, 2018

eclipseGH-28: Updated TP to use a customized LSP4J.
Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 5, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 8, 2018

eclipseGH-28: !!!FRAGMENT!!! Added support for the type hierarchy.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 9, 2018

eclipseGH-28: Added support for the super- and subtype hierarchies.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos

This comment has been minimized.

Show comment
Hide comment
@kittaakos

kittaakos Oct 9, 2018

Contributor

PR: #823

Contributor

kittaakos commented Oct 9, 2018

PR: #823

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 9, 2018

eclipseGH-28: Added support for the super- and subtype hierarchies.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>

kittaakos added a commit to kittaakos/eclipse.jdt.ls that referenced this issue Oct 11, 2018

eclipseGH-28: Added support for the super- and subtype hierarchies.
Closes: eclipse#28.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment