Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TP, again #139

Merged
merged 1 commit into from Feb 3, 2017
Merged

fix TP, again #139

merged 1 commit into from Feb 3, 2017

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Feb 2, 2017

Fixes #137

Signed-off-by: Fred Bricon fbricon@gmail.com

@fbricon
Copy link
Contributor Author

fbricon commented Feb 2, 2017

Build still fails because lsp4j 0.0.1-SNAPSHOT builds are no longer available. Unfortuinately moving to 0.0.2-SNAPSHOT is a bit tricky. See eclipse-lsp4j/lsp4j#64

Copy link

@othomann othomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Fixes eclipse-jdtls#137

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon merged commit eb623c7 into eclipse-jdtls:master Feb 3, 2017
@fbricon fbricon deleted the tpupdate branch February 3, 2017 16:30
yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this pull request Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants