Add instructions on starting server to README #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svarlamov thanks for your contribution. However, before we can merge it, you need to do 2 things:
|
gorkem
reviewed
Feb 15, 2017
|
|
||
| 5. To start the server in the active terminal, run: | ||
| ```bash | ||
| java -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044 -Declipse.application=org.eclipse.jdt.ls.core.id1 -Dosgi.bundles.defaultStartLevel=4 -Declipse.product=org.eclipse.jdt.ls.core.product -Dlog.protocol=true -Dlog.level=ALL -noverify -Xmx1G -jar ./plugins/org.eclipse.equinox.launcher_1.4.0.v20161219-1356.jar -configuration ./config_linux -data /path/to/data |
There was a problem hiding this comment.
The version of launcher (org.eclipse.equinox.launcher_1.4.0.v20161219-1356.jar) may change as the eclipse versions changes perhaps we should have a note of it.
gorkem
reviewed
Feb 15, 2017
|
@svarlamov do you have an ECA signed? I can not find a record for your email? Can you possibly sign the CLA? |
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com> Fix MD formatting Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com> Add instructions for starting the server in the README. Ref: #153 Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com> Add instructions for starting the server in the README. Ref: #153 Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
|
Signed the ECA and squashed the commits. Also just added a note about the jar file version -- should be good to go |
|
@svarlamov Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interested to see the feedback on this. I think I might be missing some deeper features/configs that would be worth highlighting