Permalink
Commits on Mar 29, 2017
  1. Bug 512001: [Webkit2] Move evaluate() logic to java

    Remove unneccessary semicolon.
    
    Change-Id: I51336839efd8cff2b100894852abb1cae2e01943
    Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
    akurtakov committed Mar 29, 2017
Commits on Mar 28, 2017
  1. v4749

    Arun Thondapu committed Mar 28, 2017
  2. Bug 441116 - [api] Create functional interface to use Lambda expressi…

    …ons for selection events based on SelectionListener
    mkeller committed Mar 28, 2017
Commits on Mar 27, 2017
  1. v4749

    Arun Thondapu committed Mar 27, 2017
  2. Bug 508570 - [cocoa][hidpi] Image(Device, Image, int) constructor

    doesn't work on retina
    
    Copy the 100% & 200% representation if available. Also, copy the
    imageData & File name providers
    
    Change-Id: I253b16a934e77135f0479c527bbb7286ceb747c4
    lshanmug committed Mar 14, 2017
Commits on Mar 26, 2017
  1. v4749

    Arun Thondapu committed Mar 26, 2017
Commits on Mar 25, 2017
  1. v4749

    Arun Thondapu committed Mar 25, 2017
Commits on Mar 24, 2017
  1. v4749

    Arun Thondapu committed Mar 24, 2017
  2. Bug 502090 - Strip _Nullable and _Nonnull information

    The bridgesupport files now contain null annotation information. We
    might be able to convert them into JDT null annotations but for now they
    should be removed and not appear in the generated output.
    
    Change-Id: I05b5caecd2ed02e5ac8d82ce48517f30b4e2c562
    Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
    guw committed with Arun Thondapu Oct 14, 2016
  3. Bug 502711 - [Cocoa][10.12]crashes on „macOS Sierra“ related to

    NSCopyBits
    
    Disable generation of code for deprecated method NSCopyBits as it is not
    used anymore
    
    Change-Id: I2163508166467a8c1a42cbdb5a0e15aaab5249ba
    Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
    Arun Thondapu committed Mar 24, 2017
Commits on Mar 23, 2017
  1. v4749

    Arun Thondapu committed Mar 23, 2017
  2. Bug 502090 - Add info about compiling native bits

    Change-Id: If2b67a10edaddfffe0d5376664362032011a5420
    Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
    guw committed with Arun Thondapu Oct 17, 2016
  3. Bug 502090 - Document macOS development information

    This is by far not complete but a start based on the information spread
    across the web, Bugzilla and forums.
    
    Change-Id: Ia92e987dd1da30d5744a6841264b851296ed4e0a
    Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
    guw committed with Arun Thondapu Oct 14, 2016
  4. Bug 502090 - Add an error for invalid enums

    This allows better debugging of enums no longer available.
    
    Change-Id: I18adf33633a8464d27b0a478201a73aec9acbd20
    Signed-off-by: Gunnar Wagenknecht <gunnar@wagenknecht.org>
    guw committed with Arun Thondapu Oct 15, 2016
  5. v4749

    Arun Thondapu committed Mar 23, 2017
  6. v4749

    Arun Thondapu committed Mar 23, 2017
  7. Bug 502711 - [Cocoa] crashes on „macOS Sierra“ related to NSCopyBits

    Replaced the calls to deprecated method NSCopyBits with
    NSView.scrollRect() in
    GC.copyArea and Canvas.scroll. Removed the native code for NSCopyBits.
    
    Change-Id: I206c76cd6af9230857967fb23641f0773f90e5de
    Signed-off-by: Till Brychcy <register.eclipse@brychcy.de>
    Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
    brychcy committed with lshanmug Sep 29, 2016
  8. Bug 502090 - [Cocoa] Bridge support files should be updated to latest

    macOS supported version
    
    Source changes generated by the MacGenerator using the updated bridge
    support files from macOS 10.10
    
    Change-Id: Id9b0cffb795bfb0b5ca304efc00ef5d8f23b86af
    Arun Thondapu committed Mar 23, 2017
Commits on Mar 22, 2017
  1. v4748

    Arun Thondapu committed Mar 22, 2017
Commits on Mar 21, 2017
  1. v4748

    Arun Thondapu committed Mar 21, 2017
  2. v4748

    Arun Thondapu committed Mar 21, 2017
  3. Bug 512001: [Webkit2] Move evaluate() logic to java

    Adding jUnit tests that test evaluation in SWT listeners.
    This used to cause early Webkit2 implementation to hang, but now works
    well.
    
    Tests:
    [x] Gtk Webkit2 & Webkit1
    [x] Cocoa
    [x] Win32
    
    Change-Id: Ic4bb453f15a2bde6ae7b62aed31d15133ba209ff
    Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=512001
    Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
    Leo Ufimtsev committed Mar 16, 2017
  4. Bug 503431 Mouse button release event memory leak fix

    The previous patch introduced a memory leak as a new callback was
    instantiated but never disposed.
    
    After investigation, that callback is redundant as the only thing it did
    was to return 'false'. This can be achieved by linking it to gtk_false()
    instead.
    
    Tasks performed:
    1) Removed redundant callback in Display.java.
    2) Linked Tree/Table/List to gtk_false() instead.
    2.b) Implemented custom getter that gets the function pointer to
    gtk_false.
    
    Tested via DNDExample, with Table/List/Tree you can still select
    multiple items and drag multiple items. (without the calls, you cannot).
    
    Gtk3: all jUnits pass.
    
    Change-Id: I9d144504acdf3548b2a11ca10dcc19d4fe42d3c6
    Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
    Leo Ufimtsev committed Mar 21, 2017
  5. Bug 513115 - GTK: MenuDetect issues with toolbar

    There is no need to manually propagate button press/release and
    event-after with Gtk3.
    
    Change-Id: If49fe007e294e1bdb2cc3bf9b2f18c338f3123e3
    Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
    akurtakov committed Mar 21, 2017
Commits on Mar 20, 2017
  1. v4747

    Arun Thondapu committed Mar 20, 2017
  2. Bug 503431 : [wayland] DND Mouse button release event not triggering fix

    The current implementation has a Callback leak. New Callback instances
    are created, but never disposed. This causes "No more callbacks" issue.
    
    After inspection, I found that drag_end was registered twice. I removed
    the duplicate Callback registration and moved the code over into the
    existing drag_end callback code.
    
    This fix makes use of "instanceof". 
    Arguably "InstanceOf" is a case of poor class coupling, but on the other
    hand without doing so one would have duplicate code in Tree/Table/List.
    This also keeps the drag-end code together in one place rather than
    scattering it.
    
    An alternative approach without using instance of would be to add a
    "drag_end"/SWT.dispose listener into Tree/Table/List in their
    constructor and run the gtk code inside that listener. Those listeners
    would be called in DragSource:DragEnd() call. However, it has the issue
    of scattering code.
    
    Change-Id: Ibf78647311e69358bd30444aeb2be6def217e19b
    Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
    Leo Ufimtsev committed Mar 20, 2017
  3. Bug 513837: [Webkit2] Occasional crash on libjavascriptcoregtk-4.0.so

    during gtk_widget_destroy
    
    Crash is not reproducible, so I have to statically determine root cause
    and submit patch(es) based on what I think could cause the crash.
    
    Suspicion 1: Webkit1 external object
    - @ Guarding off webkit1 logic that injected/freed a javascript object.
        This logic is not used by Webkit2, OS.free() is hazardous.
    - A crash occurs during javascript executing when disposing a widget, I
    have the feeling that the OS.free() could free up memory that might get
    re-freed after and causing a crash.
    
    Change-Id: Idb878371d2d0d722c3a376bb4b95cbc43df22b24
    Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=513837
    Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
    Leo Ufimtsev committed Mar 20, 2017
  4. Bug 513298 - FormLayout should give IAE for children with wrong layout

    data
    
    Change-Id: If03ea66907c13c310c4ee9bcdb2b778030090e26
    Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
    vogella committed with akurtakov Mar 8, 2017
  5. Bug 513180 - GridLayout should give IAE instead of CCE if wrong layou…

    …t data is used
    
    Change-Id: Ia6b5507fd7aee1dc6215fa976cfbc5a8b6a3cf39
    Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
    vogella committed with akurtakov Mar 6, 2017
  6. Bug 513790 - Compiler warnings in I20170316-2000 after moving to M6

    compiler
    
    Change-Id: I93bb316e6a8a72f9d263b9050b439edd96fa74ed
    Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
    iloveeclipse committed Mar 19, 2017
  7. Bug 67361 - [Program] Identical entries in "Program.getPrograms()"

    Fixed test error uncovered by the new compiler warning (see bug 513790).
    After test fix found fixed the test failure due the wrong implementation
    of Program.getPrograms() which returned array with some equal Program
    objects. Adopted Program.equals() and hashCode() where needed.
    
    Change-Id: I5f4784e504e37b352c2fcc80488fcd3c9f2051cc
    Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
    iloveeclipse committed with akurtakov Mar 19, 2017
Commits on Mar 19, 2017
  1. v4747

    Arun Thondapu committed Mar 19, 2017
Commits on Mar 18, 2017
  1. v4747

    Arun Thondapu committed Mar 18, 2017
Commits on Mar 17, 2017
  1. v4747

    Arun Thondapu committed Mar 17, 2017
  2. Webkit2 minor rename of variable name

    There is ambiguity:
      webkit_web_view_get_window_features()
    returns webKitWebWindowFeatures, 
    but currently the return value is named 'settings'. 
    
    This is easily mixed up with:
      webkit_web_view_get_settings
    Which returns actual webkit settings.
    
    No functional change, only rename of variable.
    
    Change-Id: I79a48292c3235a380ec77242c39af4ae39a36484
    Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
    Leo Ufimtsev committed Mar 17, 2017