Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[532244] adequate HTML label doubleClicking support #16

Conversation

prggz
Copy link
Contributor

@prggz prggz commented May 17, 2018

  • new DotHtmlLabelDoubleClickStrategy implemented
  • adapted DotTerminalsTokenTypeToPartitionMapper to introduce custom
    HTML label partitionType
  • custom DotDoubleClickStrategyProvider to provide
    DotHtmlLabelDoubleClickStrategy for custom HTML label partitionType
  • adapted DotHtmlLabelTerminalsTokenTypeToPartitionMapper to introduce
    custom HTML text type
  • custom DotHtmlLabelDoubleClickStrategyProvider to map text type
  • bound custom DotDoubleClickStrategyProvider in DotUiModule
  • bound custom DotHtmlLabelDoubleClickStrategyProvider in
    DotHtmlLabelUiModule
  • DotEditorDoubleClickingTests extended for HTML label cases
  • DotHtmlLabelTokenTypeToPartitionMapperTests and
    DotTokenTypeToPartitionMapperTests changed to expect amended results

Signed-off-by: Zoey Gerrit Prigge zoey.prigge@uni-duesseldorf.de
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244

- new DotHtmlLabelDoubleClickStrategy implemented
- adapted DotTerminalsTokenTypeToPartitionMapper to introduce custom
HTML label partitionType
- custom DotDoubleClickStrategyProvider to provide
DotHtmlLabelDoubleClickStrategy for custom HTML label partitionType
- adapted DotHtmlLabelTerminalsTokenTypeToPartitionMapper to introduce
custom HTML text type
- custom DotHtmlLabelDoubleClickStrategyProvider to map text type
- bound custom DotDoubleClickStrategyProvider in DotUiModule
- bound custom DotHtmlLabelDoubleClickStrategyProvider in
DotHtmlLabelUiModule
- DotEditorDoubleClickingTests extended for HTML label cases
- DotHtmlLabelTokenTypeToPartitionMapperTests and
DotTokenTypeToPartitionMapperTests changed to expect amended results

Signed-off-by: Zoey Gerrit Prigge <zoey.prigge@uni-duesseldorf.de>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244

@miklossy miklossy merged commit 5ac1bf0 into eclipse:master May 17, 2018
@prggz prggz deleted the 532244_Doubleclicking_HTML_Like_Labels_extendedSelection branch May 24, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants