[533872]: DragDropGesture to support JavaFX drag and drop events #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue tracker reference: |
miklossy
reviewed
Dec 13, 2018
| * | ||
| *******************************************************************************/ | ||
|
|
||
| package com.kdma.brm.riskmap.gestures; |
There was a problem hiding this comment.
The package name com.kdma.brm.riskmap.gestures seems to be weird. Please update the PR to use proper GEF package names.
|
Please squash the commits in the Pull Request into one single commit. That makes the review easier. |
…vents.
- Create DragDropGesture class to handle JavaFX drag drop gestures
- Create IOnDragDropHandler interface to allow objects to be notified of drag and drop events
Signed-off-by: Kyle Girard <kyle@kdmanalytics.com>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DragDropGesture to support JavaFX drag and drop events