Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[545407]: Gestures do not support scene changes #58

Merged
merged 1 commit into from Mar 15, 2019
Merged

[545407]: Gestures do not support scene changes #58

merged 1 commit into from Mar 15, 2019

Conversation

CamilleLetavernier
Copy link
Contributor

  • Add a scene change listener to all Gestures
  • Update InfiniteCanvasViewer to accept activation without a scene

@CamilleLetavernier
[545407]: Gestures do not support scene changes
f1dd177 
- Add a scene change listener to all Gestures
- Update InfiniteCanvasViewer to accept activation without a scene

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=545407
@mwienand
Copy link
Contributor

The changes are looking fine. In a follow-up, we should refactor to remove duplicated code (hooking/unhooking of scenes, listener setup, etc.), probably via enhancing AbstractGesture. I will create a separate Bugzilla in the near future. @CamilleLetavernier Thank you very much for your contribution!

@mwienand mwienand merged commit 9fd8ee2 into eclipse:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CamilleLetavernier @mwienand