Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[525304] Fix method call in Diagnostic.INFO case (DotJavaValidator.java) #6

Merged
merged 1 commit into from Sep 28, 2017

Conversation

prggz
Copy link
Contributor

@prggz prggz commented Sep 22, 2017

I noticed this working on the recordLabelValidation. I think this is a simple typo. Would be great if you could have a look. Thanks!

@nyssen
Copy link
Member

nyssen commented Sep 27, 2017

You are right. Could you please raise a Bugzilla for this, and reference it in the commit. This is how contributions will get 'traced' to releases.

@prggz
Copy link
Contributor Author

prggz commented Sep 27, 2017

Thank you for the info, I wasn't sure if its too minor to write a bug report.

I tried just now and got an internal server error on bugs.eclipse.org, I will retry later.

- Changed the method in DotJavaValidator.checkValidAttributeValue:119
Diagnostic.INFO case to match in issue severity (acceptInfo instead of
acceptError)

Signed-off-by: Zoey Gerrit Prigge <zoey.prigge@uni-duesseldorf.de>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=525304
@prggz prggz force-pushed the NONE_Typo_error_validation_attributes branch from a3da36d to 25bd522 Compare September 28, 2017 09:10
@prggz prggz changed the title [NONE] Fix method call in Diagnostic.INFO case (DotJavaValidator.java) [525304] Fix method call in Diagnostic.INFO case (DotJavaValidator.java) Sep 28, 2017
@prggz
Copy link
Contributor Author

prggz commented Sep 28, 2017

@nyssen I have updated the bug reference now.

@nyssen nyssen merged commit b8b4c8c into eclipse:master Sep 28, 2017
@prggz prggz deleted the NONE_Typo_error_validation_attributes branch March 9, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants